Fix drink milk sound

EaseCation · Oct 1, 2024 · 0df2d39 · 0df2d39
1 parent fd76af3
commit 0df2d39
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/main/java/cn/nukkit/Player.java b/src/main/java/cn/nukkit/Player.java
@@ -3291,7 +3291,7 @@ public void onCompletion(Server server) {
                                 break;
                             }
                             Item held = inventory.getItemInHand();
-                            if (!(held instanceof ItemEdible) && !held.is(Item.POTION)) {
+                            if (!(held instanceof ItemEdible) && !held.is(Item.POTION) && !held.is(Item.BUCKET, ItemBucket.MILK_BUCKET)) {
                                 break;
                             }
 

diff --git a/src/main/java/cn/nukkit/item/ItemBucket.java b/src/main/java/cn/nukkit/item/ItemBucket.java
@@ -412,6 +412,7 @@ public boolean onUse(Player player, int ticksUsed) {
         }
 
         if (!player.isCreative()) {
+            pop();
             player.getInventory().setItemInHand(get(BUCKET));
         }