Set update / Clear external charging limits #828
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shankari - this is ready for your review. |
Creates an initial implementation for handling K12 that takes in an external limit and its delta from previous limits and determines whether or not to send a notification to the CSMS. We expose a public function on the ChargePoint so that some external system (such as the energy manager) may call it to alert us of the external limit. Signed-off-by: Christopher Davis <[email protected]>
Ensure we either build a charging schedule from a given limit or use the given charging schedule and return it in our notification to the CSMS. Signed-off-by: Christopher Davis <[email protected]>
Take in the charging limit source, and ensure we don't propagate a source of CSO in the off chance we receive it. Signed-off-by: Christopher Davis <[email protected]>
When receiving an external limit from another system, we need to know two things: the limit, and what unit the limit is in. Previously we only knew the limit (if we're not given a schedule) and made up a unit. Now when we receive a constant charging limit we take it as the new type ConstantChargingLimit, which holds the limit and the unit. Signed-off-by: Christopher Davis <[email protected]>
Signed-off-by: Christopher Davis <[email protected]>
Signed-off-by: Christopher Davis <[email protected]>
Signed-off-by: Coury Richards <[email protected]>
Signed-off-by: Coury Richards <[email protected]>
…d TransactionEventRequest Signed-off-by: Coury Richards <[email protected]>
…is cleared Signed-off-by: Coury Richards <[email protected]>
…ut some details are still needed. Signed-off-by: Coury Richards <[email protected]>
Signed-off-by: Coury Richards <[email protected]>
Signed-off-by: Coury Richards <[email protected]>
Signed-off-by: Coury Richards <[email protected]>
Signed-off-by: Coury Richards <[email protected]>
Signed-off-by: Coury Richards <[email protected]>
Signed-off-by: Coury Richards <[email protected]>
couryrr-afs
force-pushed
the
feature/k12-set-update-external-limits
branch
from
60226e9
to
075ab82
Compare
shankari
suggested changes
Oct 15, 2024
Comment on lines
+628
to
+638
| ChargingSchedule create_schedule_from_limit(const ConstantChargingLimit limit) { | ||
| return ChargingSchedule{ | ||
| .id = 0, | ||
| .chargingRateUnit = limit.charging_rate_unit, | ||
| .chargingSchedulePeriod = {ChargingSchedulePeriod{ | ||
| .startPeriod = 0, | ||
| .limit = limit.limit, | ||
| }}, | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
future fix/discussion: I understand that the intention of K11 was to specify hard grid limits directly to the charge station. However, tariffs are generally a better option to influence demand than hard limits because they are more flexible. As far as I can tell, OpenADR supports dynamic pricing.
Could pricing information could also be specified by the external controllers @RobertDeLeeuw?
This does not need to be addressed in this PR, this is purely for the community to decide how to track this potential requirement in the future
Signed-off-by: Coury Richards <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This is the implementation for section 5.2. External Charging Limit based Smart Charging of SmartCharging in OCPP2.0.1.
We expose two methods on the
ChargePointto be called when external limit events occur.on_external_limits_changed- covering the case for setting or changing an external limit.on_external_limits_cleared- covering the case when an external limit is removed when a transaction is ongoing.These methods can be invoked by the systems withing the Charging Station that interact with the DSO and will handle the ocpp communication to the CSMS.
Issue ticket number and link
Checklist before requesting a review