Handle of invalid datetime when format check fails #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Rogach <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
…-datetime-when-format-check-fails
Signed-off-by: Kai-Uwe Hermann <[email protected]>
…-datetime-when-format-check-fails # Conflicts: # CMakeLists.txt
maaikez
reviewed
Oct 8, 2024
| @@ -53,8 +43,7 @@ void DateTimeImpl::from_rfc3339(const std::string& timepoint_str) { | |||
| in.seekg(0); | |||
| in >> date::parse("%FT%T", this->timepoint); | |||
| if (in.fail()) { | |||
| EVLOG_error << "Timepoint string parsing failed. Could not convert: \"" << timepoint_str | |||
| << "\" into DateTime."; | |||
| throw TimePointParseException(timepoint_str); | |||
There was a problem hiding this comment.
Hmm now you added a throw where the software did not crash in the past. Did you check everywhere this is used and provide a try / catch around it if needed?
There was a problem hiding this comment.
Well, the std::string constructor calls only when json is converted to the DateTime type or in database conversions. In other places the constructor is not (should not be) called. So then it should be caught either by TimePointParseException or std::exception, that is done. From my side and for 2.0.1, I don't see the missing places. @hikinggrass can approve as well for 1.6
marcemmers
reviewed
Oct 9, 2024
Signed-off-by: Ivan Rogach <[email protected]>
maaikez
approved these changes
Oct 15, 2024
jannejy
changed the title
jannejy
deleted the
808-handle-of-invalid-datetime-when-format-check-fails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review