Add critical and timestamp parameters to on_security_event functions #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds "critical" and "timestamp" parameters to the on_security_event functions for OCPP 1.6 and 2.0.1 Criticality is by default determined based on the 1.6 security whitepaper, but can be overwritten externally By default the current datetime is used for the timestamp, but this can also be overwritten externally (for example if the event occured earlier) Signed-off-by: Kai-Uwe Hermann <[email protected]>
hikinggrass
requested review from
Pietfried,
marcemmers and
maaikez
as code owners
Signed-off-by: Kai-Uwe Hermann <[email protected]>
hikinggrass
deleted the
feature/set-timestamp-for-ocpp-security-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds "critical" and "timestamp" parameters to the on_security_event functions for OCPP 1.6 and 2.0.1
Criticality is by default determined based on the 1.6 security whitepaper, but can be overwritten externally
By default the current datetime is used for the timestamp, but this can also be overwritten externally (for example if the event occured earlier)
Describe your changes
Issue ticket number and link
Checklist before requesting a review