refactor: Replace get_vector_from_csv with split_string

[mlitre]

Removed references to get_vector_from_csv by split_string since this last method is more extensible / reusable.

Describe your changes

Issue ticket number and link

Issue #721

Checklist before requesting a review

• I have performed a self-review of my code
• I have made corresponding changes to the documentation
• If OCPP 2.0.1: I have updated the OCPP 2.0.1 status document
• I read the contribution documentation and made sure that my changes meet its requirements

[maaikez]

Maybe you can also remove the function completely? Or is it still useful?

[mlitre]

Maybe you can also remove the function completely? Or is it still useful?

I did not remove to avoid a breaking change. If I'm not mistaken, I saw that this was a public utility so any lib user would get issues if they were using the old method. I do agree that it would be simpler to just remove the function. If that is preferred I can go ahead and do that.

[maaikez]

Maybe you can also remove the function completely? Or is it still useful?

I did not remove to avoid a breaking change. If I'm not mistaken, I saw that this was a public utility so any lib user would get issues if they were using the old method. I do agree that it would be simpler to just remove the function. If that is preferred I can go ahead and do that.

Yes I understand what you say.
I'm thinking then we can never remove such functions, and for this particular case, there is a replacement. So I would opt for removing it, otherwise other people will use it later again.

What do you think?

[mlitre]

@maaikez fair enough it seems to me to be a pretty low impact change. I'll go ahead and remove the function.

[mlitre]

@maaikez I've gone ahead and removed the method. Let me know if there are other things I missed in terms of code or process for merging changes / contributing. Thanks!

[maaikez]

It looks good. Did you somehow check if things still work (except from the unittests)?

[maaikez]

Thanks for contributing!

[mlitre]

It looks good. Did you somehow check if things still work (except from the unittests)?

I have not done much extra testing to be honest, but if necessary I can run some.