-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/k02 05 cumulative #760
Conversation
@shankari - this is ready for your review. |
870170a
to
601228c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks good to me. The most relevant in line comment is about how to handle a profile that is not a TxProfile
as part of a RequestStartTransactionRequest
.
This branch currently has conflicts that need to be resolved.
601228c
to
7020c2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
8740842
to
9dabfec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some suggested cleanup changes, but nothing to hold up approval.
58ffa24
to
7aa94d3
Compare
@Pietfried - looks like we are failing here with a SegFault again. This passed yesterday just fine none of the recent updates changes behavior for the code. |
@shankari I responded to your comments. Should this be approved? |
K04.FR.01 states that charging schedules should be managed per EVSE. This commit adds a test (and a helper function, `get_profiles_on_evse()`) to verify that profiles are EVSE-specific are only applied to that EVSE. Signed-off-by: Christopher Davis <[email protected]>
Use the new `get_profiles_for_evse()` helper function. Signed-off-by: Christopher Davis <[email protected]>
…file Signed-off-by: pietfried <[email protected]>
- removed AddChargingProfileSource::Unknown defaults to AddChargingProfileSource::SetChargingProfile for the most validation checks. - added a check on SmartChargingCtrlrAvailableEnabled for F01.FR26, K05.FR04 and K05.FR05 - added check for ChargingProfilePurposeEnum::TXProfile K05.FR02 Signed-off-by: Coury Richards <[email protected]>
Delete transaction-specific profile from database. When the transaction ends, then delete TxProfiles. Signed-off-by: Christoph <[email protected]> Co-authored-by: Gianfranco Berardi <[email protected]>
Signed-off-by: Gianfranco Berardi <[email protected]>
…charging profile Signed-off-by: Coury Richards <[email protected]>
Signed-off-by: Coury Richards <[email protected]>
7aa94d3
to
a609bb3
Compare
@Pietfried this has been rebased and is ready to be merged. |
Describe your changes
get_profiles_on_evse()
to verify that profiles are EVSE-specific and are only applied to that EVSE.AddChargingProfileSource
to distinguish profile source for validation. Specifically, whenvalidate_and_add_profile
is called fromRequestStartTransactionRequest
.AddChargingProfileSource::Unknown
defaults toAddChargingProfileSource::SetChargingProfile
for the most validationchecks.
SmartChargingCtrlrAvailableEnabled
for F01.FR26,K05.FR04 and K05.FR05
Issue ticket number and link
Checklist before requesting a review