Feature/k02 05 cumulative #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shankari - this is ready for your review. |
couryrr-afs
force-pushed
the
feature/k02-05-cumulative
branch
from
870170a
to
601228c
Compare
Pietfried
requested changes
Sep 4, 2024
couryrr-afs
force-pushed
the
feature/k02-05-cumulative
branch
from
601228c
to
7020c2f
Compare
couryrr-afs
force-pushed
the
feature/k02-05-cumulative
branch
2 times, most recently
from
8740842
to
9dabfec
Compare
shankari
approved these changes
Sep 6, 2024
couryrr-afs
force-pushed
the
feature/k02-05-cumulative
branch
2 times, most recently
from
58ffa24
to
7aa94d3
Compare
|
@Pietfried - looks like we are failing here with a SegFault again. This passed yesterday just fine none of the recent updates changes behavior for the code. |
|
@shankari I responded to your comments. Should this be approved? |
|
It was approved 10 hours ago 
|
couryrr-afs
requested review from
hikinggrass,
marcemmers and
maaikez
as code owners
K04.FR.01 states that charging schedules should be managed per EVSE. This commit adds a test (and a helper function, `get_profiles_on_evse()`) to verify that profiles are EVSE-specific are only applied to that EVSE. Signed-off-by: Christopher Davis <[email protected]>
Use the new `get_profiles_for_evse()` helper function. Signed-off-by: Christopher Davis <[email protected]>
…file Signed-off-by: pietfried <[email protected]>
- removed AddChargingProfileSource::Unknown defaults to AddChargingProfileSource::SetChargingProfile for the most validation checks. - added a check on SmartChargingCtrlrAvailableEnabled for F01.FR26, K05.FR04 and K05.FR05 - added check for ChargingProfilePurposeEnum::TXProfile K05.FR02 Signed-off-by: Coury Richards <[email protected]>
Delete transaction-specific profile from database. When the transaction ends, then delete TxProfiles. Signed-off-by: Christoph <[email protected]> Co-authored-by: Gianfranco Berardi <[email protected]>
Signed-off-by: Gianfranco Berardi <[email protected]>
…charging profile Signed-off-by: Coury Richards <[email protected]>
Signed-off-by: Coury Richards <[email protected]>
couryrr-afs
force-pushed
the
feature/k02-05-cumulative
branch
from
7aa94d3
to
a609bb3
Compare
|
@Pietfried this has been rebased and is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
get_profiles_on_evse()to verify that profiles are EVSE-specific and are only applied to that EVSE.AddChargingProfileSourceto distinguish profile source for validation. Specifically, whenvalidate_and_add_profileis called fromRequestStartTransactionRequest.AddChargingProfileSource::Unknowndefaults toAddChargingProfileSource::SetChargingProfilefor the most validationchecks.
SmartChargingCtrlrAvailableEnabledfor F01.FR26,K05.FR04 and K05.FR05
Issue ticket number and link
Checklist before requesting a review