Device Model - hardwired monitors #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AssemblyJohn
force-pushed
the
feature/hardwired_monitors
branch
from
8226e52
to
357a722
Compare
AssemblyJohn
changed the title
|
Comments: code comments related to the spec functional requirements should be put into place |
Pietfried
requested changes
Aug 8, 2024
AssemblyJohn
force-pushed
the
feature/hardwired_monitors
branch
from
8564743
to
aaccfd3
Compare
AssemblyJohn
requested review from
hikinggrass,
marcemmers and
maaikez
as code owners
|
Comments implemented, ready for review. |
AssemblyJohn
force-pushed
the
feature/hardwired_monitors
branch
4 times, most recently
from
f067889
to
3230cbb
Compare
|
Documentation has been added. |
AssemblyJohn
force-pushed
the
feature/hardwired_monitors
branch
from
3230cbb
to
1633a6d
Compare
|
Fixed for the last PR. |
Pietfried
requested changes
Aug 12, 2024
AssemblyJohn
force-pushed
the
feature/hardwired_monitors
branch
from
569f455
to
90386b6
Compare
|
All comments have been implemented, a flow chart will follow explaining the monitor usage. |
AssemblyJohn
force-pushed
the
feature/hardwired_monitors
branch
5 times, most recently
from
ced958e
to
cf2a278
Compare
AssemblyJohn
force-pushed
the
feature/hardwired_monitors
branch
from
cf2a278
to
a9e41c1
Compare
…MS) and hardwired (not modifiable by the CSMS) Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
… offline, since a 'fake' online status can have the consequence of events being dropped Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
feature/hardwired_monitors
branch
2 times, most recently
from
2a53504
to
3adb0f1
Compare
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
feature/hardwired_monitors
branch
from
3adb0f1
to
b9f07ee
Compare
Signed-off-by: AssemblyJohn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds the possibility of adding preconfigured or hardwired monitors in the database configuration file.
Not supported in this PR:
N07.FR.14 - requires trigger persistance in the database
N04.FR.15 - requires a re-parsing of the configuration file and an extra column in the database to know the original type of the configuration. The re-parsing of the configuration json file has to be done at runtime, and all the monitors have to be parsed and must be matched against the current database monitors based on identification criteria that also has to be persisted.
New passes on OCTT tool N test cases:
TC_N_20_CS - Tool bug was fixed, test passes
TC_N_52_CS - Tool bug was fixes, test passes
Issue ticket number and link
Closes: #640
Built on top of: #686
Checklist before requesting a review