Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark methods as override #735

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Mark methods as override #735

merged 2 commits into from
Aug 14, 2024

Conversation

kromahn
Copy link
Contributor

@kromahn kromahn commented Aug 7, 2024

Describe your changes

To improve code readability and maintenance, all overriding methods are marked with keyword override (allows to enable warning-free the compile options "-Wsuggest-override").

Issue ticket number and link

Checklist before requesting a review

Signed-off-by: Katja Romahn <[email protected]>
@kromahn kromahn marked this pull request as ready for review August 7, 2024 15:12
@marcemmers marcemmers self-assigned this Aug 8, 2024
@marcemmers
Copy link
Contributor

Hi @kromahn,

Thanks for the contribution. Looks like a good improvement!
We do have some code generators in place that can generate these message definitions, could you update those as well?

They're located in src/code_generator/common/templates/. I expect that once you update that the output will look the same.

@marcemmers marcemmers merged commit d967fcf into EVerest:main Aug 14, 2024
4 checks passed
Pietfried pushed a commit that referenced this pull request Aug 14, 2024
* Mark methods as override

Signed-off-by: Katja Romahn <[email protected]>

* Update templates for code generation

Signed-off-by: Katja Romahn <[email protected]>

---------

Signed-off-by: Katja Romahn <[email protected]>
Co-authored-by: Katja Romahn <[email protected]>
Co-authored-by: Katja Romahn <[email protected]>
Pietfried pushed a commit that referenced this pull request Aug 14, 2024
* Mark methods as override

Signed-off-by: Katja Romahn <[email protected]>

* Update templates for code generation

Signed-off-by: Katja Romahn <[email protected]>

---------

Signed-off-by: Katja Romahn <[email protected]>
Co-authored-by: Katja Romahn <[email protected]>
Co-authored-by: Katja Romahn <[email protected]>
Signed-off-by: pietfried <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants