Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added verifications before calling callbacks #725

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

AssemblyJohn
Copy link
Contributor

@AssemblyJohn AssemblyJohn commented Aug 1, 2024

Describe your changes

Added checks for functors before an actual call to it.

Issue ticket number and link

Checklist before requesting a review

@Pietfried
Copy link
Contributor

Did you understand how it could happen that these callbacks are nullptr when they are called?

@AssemblyJohn
Copy link
Contributor Author

No, I could not find any culprit in that case. An initial theory was that the callback captures the 'this' pointer and that somehow becomes stale, but it is improbable, since in that case we would probably have a segfault.

@Pietfried Pietfried self-assigned this Sep 3, 2024
@Pietfried Pietfried merged commit 591c978 into main Sep 8, 2024
4 checks passed
@Pietfried Pietfried deleted the bugfix/wrong_functor_access branch September 8, 2024 11:55
SNSubramanya pushed a commit that referenced this pull request Sep 11, 2024
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants