fix(string_stream): add missing initializations of const format specifiers #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fiers The const variables "left" and "right" are const default initialized. The C++ standard states the following: "A class type T is const-default-constructible if default-initialization of T would invoke a user-provided constructor of T." Since the "left_soec" and "right_spec" structs are PODs they are not initialized per default. Due to the "constness" the variable can not be modified later one, therefore the POD is in a state in which it is not useful at all. Since the mentioned structs are empty there would be no problem in this case. This is an issue in the C++ standard (CWG Issue 253). Some compilers already handle this issue with their own solution despite the fact, that the standard did not provide a solution yet. For some exotic compilers (e.g. Tasking for TriCore) the include of the "string_stream" header caused compilation errors: "const variable "etl::left" requires an initializer -- class "etl::private_basic_format_spec::left_spec" has no user-provided default constructor" References: https://en.cppreference.com/w/cpp/language/default_initialization https://cplusplus.github.io/CWG/issues/253.html https://stackoverflow.com/questions/7411515/why-does-c-require-a-user-provided-default-constructor-to-default-construct-a https://stackoverflow.com/questions/24943665/why-is-a-constructor-necessary-in-a-const-member-struct
|
Review changes with SemanticDiff. |
|
Were you getting warning from the compiler? |
|
Warning about what/where? |
|
Did you get errors or warnings about 'missing initializers'? |
|
Yeah, i got compiler errors about missing initializers for Yes, the structs |
jwellbelove
changed the base branch from
development
to
pull-request/#849-fix-string_stream-add-missing-initializations-of-const-format-specifiers
jwellbelove
merged commit 7c24f66
into
ETLCPP:pull-request/#849-fix-string_stream-add-missing-initializations-of-const-format-specifiers
62 of 63 checks passed
jwellbelove
pushed a commit
that referenced
this pull request
Mar 10, 2024
…izations-of-const-format-specifiers' into development # Conflicts: # support/Release notes.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a possible fix for the issue #848 by adding the missing initializers.