Fix etl::expected assignment from etl::unexpected #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View changes with SemanticDiff |
jwellbelove
changed the base branch from
master
to
pull-request/#733-Fix-etl--expected-assignment-from-etl--unexpected
jwellbelove
merged commit 9cd491e
into
ETLCPP:pull-request/#733-Fix-etl--expected-assignment-from-etl--unexpected
58 checks passed
jwellbelove
added a commit
that referenced
this pull request
Jul 18, 2023
Added unit tests for changes
jwellbelove
added a commit
that referenced
this pull request
Jul 18, 2023
Added unit tests for changes Added missing etl::forward in etl::expected::emplace
jwellbelove
added a commit
that referenced
this pull request
Jul 18, 2023
…--unexpected' into development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment operator of etl::expected form etl::unexpected attempts to save etl::unexpected to storage instead of the contained error.