Conditionally explicit etl::expected constructors that work in C++11 #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwellbelove
changed the base branch from
master
to
pull-request/#719-Conditionally-explicit-etl--expected-constructors-that-work-in-C++11
jwellbelove
merged commit 70fd6fd
into
ETLCPP:pull-request/#719-Conditionally-explicit-etl--expected-constructors-that-work-in-C++11
58 checks passed
jwellbelove
pushed a commit
that referenced
this pull request
Jul 1, 2023
jwellbelove
added a commit
that referenced
this pull request
Jul 1, 2023
…constructors-that-work-in-C++11' of https://github.com/ETLCPP/etl into pull-request/#719-Conditionally-explicit-etl--expected-constructors-that-work-in-C++11
jwellbelove
pushed a commit
that referenced
this pull request
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
etl::expectedcan be annoying below C++20 because constructors frometl::unexpectedare always explicit.Because of this it is not possible to use
return etl::unexpected()in functions that returnetl::expected.This is my attempt at making the constructor conditionally explicit for C++11 and up.