Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen type for module command to allow options to be passed before subcommand #4565

Conversation

mvdebolskiy
Copy link
Contributor

This is needed for some versions of lua, since otherwise it will not recognize options like --force and --quiet which will not allow a case to be created. NCName, on the other hand does not allow to -- to be start of the name.

Similar to #4375

Test suite:
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]

Fixes [CIME Github issue #]

User interface changes?:
N
Update gh-pages html (Y/N)?:
N

@jedwards4b
Copy link
Contributor

@mvdebolskiy we already have a mechanism to provide this.
<module_system type="module" allow_error="true">
Will allow lua to return errors without triggering a cime failure.

@jedwards4b
Copy link
Contributor

I guess maybe I can see a case where the allow_error feature may not be adequate but could you confirm please.

@mvdebolskiy
Copy link
Contributor Author

That option works. The model builds. The only concern I have is when sigma2 upgrades the machines and deprecates some toolchains, it will be harder to debug. But all good. Should I close this?

@jedwards4b
Copy link
Contributor

This is a concern on every machine, not in our control.

@jedwards4b jedwards4b closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants