Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User specified history write frequency #353

Merged

Conversation

nmizukami
Copy link
Collaborator

@nmizukami nmizukami commented Mar 9, 2023

User can specify output write frequency with new control variable

<outputFrequency> daily ! output frequency: integer for multiple of simulation time steps or daily, monthly or yearly

Other minor changes:
maximum IRF unit-hydrograph future time steps are detected and used for dimension size in restart file

TO-DO (near future work):
Need to implement reading accumulated value and number of accumulation time steps in restart reading routine to properly restart. This reading is only necessary when accumulation time steps in restart is not zero (i.e., previous run stop before it write out).

This should be backward compatibility.

@nmizukami nmizukami added cesm-coupling For cesm coupling new features Adding new features standalone For stand-alone run labels Mar 9, 2023
@nmizukami nmizukami requested a review from ekluzek March 10, 2023 13:37
@nmizukami nmizukami changed the title User specified output write frequency User specified history write frequency Mar 11, 2023
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions on comments to add. And a few things to think about.

route/build/src/histVars_data.f90 Outdated Show resolved Hide resolved
route/build/src/histVars_data.f90 Show resolved Hide resolved
route/build/src/histVars_data.f90 Show resolved Hide resolved
route/build/src/histVars_data.f90 Show resolved Hide resolved
route/build/src/historyFile.f90 Show resolved Hide resolved
route/build/src/public_var.f90 Outdated Show resolved Hide resolved
route/build/src/read_control.f90 Show resolved Hide resolved
route/build/src/read_control.f90 Show resolved Hide resolved
@nmizukami nmizukami merged commit 6e2dc36 into ESCOMP:cesm-coupling Mar 30, 2023
@nmizukami nmizukami deleted the cesm-coupling_outputFrequency branch March 30, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cesm-coupling For cesm coupling new features Adding new features standalone For stand-alone run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants