Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Externals.cfg to cesm2_3_beta17 and remove mct #2539

Merged
merged 46 commits into from
May 28, 2024

Update ChangeLog with latest info about tests

26c1222
Select commit
Loading
Failed to load commit list.
Merged

Update Externals.cfg to cesm2_3_beta17 and remove mct #2539

Update ChangeLog with latest info about tests
26c1222
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-05-28 22:09:19 ago

5 / 6 tasks completed

1 task still to be completed

Details

Required Tasks

Task Status
For the SETUP failure above, bisect between ccs_config_cesm0.0.92 and 106 until I find where it first fails. Note: Incomplete
This test was expected to fail in SHAREDLIB_BUILD Incomplete
the SETUP error starts with version 99 Incomplete
Try similar approach for all the failures: Incomplete
On izumi it's probably cmeps
cmeps0.14.50 PASS
cmeps0.14.51 FAIL new error Incomplete
For FUNIT, I had to bring back a CMakeLists.txt file that I had removed Incomplete
For LILAC, this far I have confirmed that it's not ccs_config (by running with version 99 as above) and that it's not cime (by running cime6.0.217_httpsbranch03); I backed out various changes and continued to get the same error; Erik suggested this, but I still got the same error. Jim E. posted that I should not have removed mct, so I will reverse that commit and try again.
(UPDATE about LILAC appears below, based on which version 99 here is not likely a typo, and I may have confused myself with these earlier tests.) Incomplete
I thought you would checkout the branch from the PR Incomplete
Instead you ended up with my cmeps0.14.50 test, which passes Incomplete
Copy my Externals.cfg again to get it with cmeps0.14.60
Now I would expect the failure to repeat. Incomplete
In my local branch I have reverted the removal of /src/cpl/mct and I am ready to push to here Incomplete
Do you need me to revert anything else mct-related or other? Incomplete
Also to confirm beyond doubt: the instruction to remove mct that I followed in this post was mistaken? Incomplete
PASS Test with ctsm5.2.004 (no change) OR change all externals except keep ccs_config version 92 or 93 or 94 Incomplete
FAIL Change all externals except keep ccs_config version 95 Incomplete
FAIL with same error, tests with cf1a297 (change all externals) and later (ccce061, db147cd, 3d1ab9b) Incomplete
PASS Change all externals except keep ccs_config version 94 Incomplete
FAIL Change all externals except keep ccs_config version 95. This failing test is here:
/glade/derecho/scratch/slevis/LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.derecho_intel.clm-lilac.C.20240517_144532_pmf0rk
Code is here: /glade/work/slevis/git/latest_master
git branch: upd_externals_to_beta17
git describe: ctsm5.2.004-19-ge4544510e
git diff: Incomplete
@slevis-lmwg did you put some workaround in place? Incomplete
Could it be a difference in our environments? Incomplete
Could it be a difference between running this as a single test vs. a test suite? Incomplete
Unfortunately it failed for me again in aux_clm as before:
/glade/work/slevis/git/latest_master/tests_0521-114730de/LILAC...
I compared my CaseDocs to yours and nothing jumped out as strange.
In the same directory I saved LILAC_dif_from_billsacks.out which compares my test directory for this test against yours. A few differences stand out, but ones for which I do not know the meaning. Incomplete
Then I tried the way that you submitted the test:
./run_sys_tests --walltime 0:30:00 -t LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.derecho_intel.clm-lilac --skip-compare --skip-generate and it failed the same way. Incomplete
Then I added the -V line to machines/config_batch.xml (as discussed earlier in this PR) and tried rerunning the test three different ways: Incomplete
The way you did: PASS Incomplete
From ./create_test: PASS Incomplete
From the aux_clm test directory that had originally failed. I even tried ./case.build --clean-all followed by ./case.build, but it didn't work. Incomplete
Erik got the same error that I get when running without the -V option. I feel some kind of selfish relief from that result. Incomplete
Bill, I ran this test without the -V option (I hope I didn't misunderstand and run the opposite case than the one you requested):
/glade/derecho/scratch/SMS_Ln9.f10_f10_mg37.I1850Clm45Bgc.derecho_intel.clm-clm45cam4LndTuningModeZDustSoilErod.20240522_171510_yc8o9d Incomplete
Sam's failing LILAC test (run without -V) Incomplete
Sam's passing LILAC test (run WITH -V) Incomplete
Sam's passing SMS test (run without -V) Incomplete
My passing LILAC test (run without -V: for some reason it passes for me even though it fails for Sam) Incomplete
share1.0.18: now both tests appear DIFF from baseline again. I now see that I confused myself last week into thinking that this was fixed. I likely forgot to rerun ./manage_externals/checkout_externals after bisecting. Incomplete
cmeps0.14.50: the f45 test is DIFF from ctsm5.2.005 and the diffs are identical when using cmeps0.14.63 Incomplete
ccs_config_cesm0.0.98: the f45 test FAILs to build Incomplete
ctsm5.2.005 Externals.cfg except keep ccs_config_ccsm0.0.106 and mizuRoute: the f45 test is DIFF from ctsm5.2.005 and the diffs are identical with ctsm5.2.006 Externals.cfg Incomplete
One reference I see with "git grep -i mct" that I think should be removed is: Completed
The changes to src/main/glc2lndMod.F90 I mention Completed
I've outlined more that I think should be done here in #2279. Completed
Remove the src/cpl/mct directory and it's entire contents Completed
Looks like there are still outstanding tests failing, that should be gotten to work Incomplete
Remove cime_config/testdefs/testmods_dirs/clm/nuopc_cap_bfb directory Completed