Fix aux history files for use_float=.true. #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* don't print messages if nstate is not created
jedwards4b
approved these changes
Jul 26, 2024
mvertens
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes aux history output to correctly implement
use_float = .true..For UFS, fixes mediator history write for ocnalb_a and aoflux_a FBs when ATM is a CSG or regional (single tiled) domain.
Fixes garbled print message for global scalar dimensions when component exists but NState does not
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
Aux history files generated with the current code and with
use_float=.true.would be expected to be different. UFS currently has no comparison case for aux history files.Any User Interface Changes (namelist or namelist defaults changes)?
No
Testing performed
Using UFS, instantaneous and average aux history files for OCN were generated for two cases: current code (ce9cfe2) with
use_float=.false.hardwired and with this feature branch. The file output was compared usingcprnc -m r4file r8file. All fields were reported as B4B, and 10 fields were marked as different data types.