renames ww3dev to ww3 #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvertens
requested changes
May 16, 2024
| @@ -127,7 +127,7 @@ def _create_drv_namelists(case, infile, confdir, nmlgen, files): | |||
| elif case.get_value("RUN_TYPE") == "branch": | |||
| config["run_type"] = "branch" | |||
|
|
|||
| config['wav_ice_coupling'] = config['COMP_WAV'] == 'ww3dev' and config['COMP_ICE'] == 'cice' | |||
| config['wav_ice_coupling'] = 'ww3' in config['COMP_WAV'] and config['COMP_ICE'] == 'cice' | |||
There was a problem hiding this comment.
Can we please make this backwards compatible with the previous version by adding
config['COMP_WAV'] == 'ww3dev' or config['COMP_WAV'] == 'ww3'
That way we can use this in NorESM for now.
There was a problem hiding this comment.
I did that. ww3 is a substring of ww3dev and so 'ww3' in config['COMP_WAV'] works for both.
There was a problem hiding this comment.
Sorry - I did not catch that. Looks good.
mvertens
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
One line change so that ww3dev can be renamed ww3
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed
Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing