Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce orbital parameters output to log #33

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

jedwards4b
Copy link

@jedwards4b jedwards4b commented Sep 26, 2024

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Reduces the printing of Orbital parameters to the ice.log file in cesm
  • Developer(s):
    Jim Edwards
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Test
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.
    The orbital parameters were being printed every timestep and created an unreadable ice.log file. This PR reduces the print of orbital parameters to once each orbital year.

@jedwards4b
Copy link
Author

@dabail10 I have one more update coming before you merge...

@jedwards4b
Copy link
Author

@dabail10 Okay - this is ready. I tested in PFS_P5376.ne30pg3_ne30pg3_mg17.FMTHIST.derecho_intel

@jedwards4b jedwards4b merged commit 41b80a3 into ESCOMP:main Sep 27, 2024
1 check passed
@jedwards4b jedwards4b deleted the orbital_parameters_logging branch September 27, 2024 17:51
@dabail10
Copy link
Collaborator

dabail10 commented Oct 9, 2024

Sorry, these should have gone to the consortium first. I need to revert them to fix main. I will save the hash.

@jedwards4b
Copy link
Author

These are specific to the nuopc interface and only used by cesm so I'm not sure why they need to go through the consortium?

@dabail10
Copy link
Collaborator

dabail10 commented Oct 9, 2024

A couple reasons. The NUOPC / CMEPS cap is used by other groups (NOAA / UFS and the Australian ACCESS-NRI group). Also, this cap is under cicecore/drivers which is maintained by the Consortium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants