Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set nx_global and ny_global == 0 #31

Closed
wants to merge 1 commit into from

Conversation

jedwards4b
Copy link

PR checklist

  • Short (1 sentence) summary of your PR:
    Initialize NX_GLOBAL and NY_GLOBAL for SCAM case
  • Developer(s):
    Jim Edwards
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    SMS_D_Ln9.T42_T42.FSCAM.derecho_intel.cam-outfrq9s
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

The CMEPS mediator needs the global_nx and global_ny field from each active component, they were not being set by cice for the scam case.

@jedwards4b jedwards4b requested a review from dabail10 May 16, 2024 21:23
Copy link
Collaborator

@dabail10 dabail10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Can these be merged after the git-fleximod stuff?

@jedwards4b
Copy link
Author

Yes, that would be fine.

@jedwards4b
Copy link
Author

@dabail10 it looks like your macos test needs an update - the error has nothing to do with my change.

@dabail10
Copy link
Collaborator

Here is a silly question. Where is that file?

@jedwards4b
Copy link
Author

@dabail10
Copy link
Collaborator

Got it. There was a fix to the github actions workflow that Tony added a couple weeks ago. I have updated CICE main and I will add it to cesm_cice6_4_0_10.

@dabail10 dabail10 closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants