Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Try to work on tests on top of upgrades #462

Merged
merged 4 commits into from
Jul 9, 2024
Merged

fix: Try to work on tests on top of upgrades #462

merged 4 commits into from
Jul 9, 2024

Conversation

richtera
Copy link
Collaborator

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?

What is the current behaviour (you can also link to an open issue here)?

What is the new behaviour (if this is a feature change)?

Other information:

@richtera richtera changed the base branch from develop to feat/upgrades June 29, 2024 01:31
@richtera
fix: Normalize tests and add name as a constant in the schema. Add no…
95dabb2 
…nDynamicName to capture resolved schema names.
@richtera richtera marked this pull request as ready for review July 2, 2024 11:17
CJ42
CJ42 requested changes Jul 9, 2024
View reviewed changes
src/index.test.ts Outdated Show resolved Hide resolved
src/lib/schemaParser.test.ts Show resolved Hide resolved
src/types/ERC725JSONSchema.ts Outdated Show resolved Hide resolved
src/types/ERC725JSONSchema.ts Outdated Show resolved Hide resolved
@richtera richtera merged commit a99f8c5 into feat/upgrades Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CJ42 CJ42 CJ42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richtera @CJ42