Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use symfony/polyfill-php80 #1042

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Oct 21, 2024

Fixes #816


以下 Copilot actions のコメント

This pull request includes several changes to improve compatibility and clean up deprecated code. The most important changes include adding a new dependency to composer.json, removing deprecated PHP compatibility functions, and updating the PHPStan configuration.

Dependency updates:

Code cleanup:

  • data/class/SC_Initial.php: Removed the compatPhp method and its call in the init method, as it contained deprecated PHP compatibility functions that are no longer needed. ([1], [2])

Configuration updates:

  • phpstan.neon.dist: Removed an unnecessary PHPStan error ignore rule related to inner named functions, as it is no longer applicable. ([phpstan.neon.distL41-L43](https://github.com/EC-CUBE/ec-cube2/pull/1042/files#diff-6f19df6a6307a48db0940e6897591fb08776d2db8a6134737aa708defdb5c92dL41-L43))

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.76%. Comparing base (cdefe2a) to head (d685168).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
+ Coverage   51.67%   51.76%   +0.08%     
==========================================
  Files          80       80              
  Lines       10157    10195      +38     
==========================================
+ Hits         5249     5277      +28     
- Misses       4908     4918      +10     
Flag Coverage Δ
tests 51.76% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP8 互換関数を外部ライブラリへ移行する
1 participant