4.3対応 #93
Merged
4.3対応 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chihiro-adachi
force-pushed
the
migration-4.3
branch
from
920fe60
to
7edc055
Compare
dotani1111
reviewed
Feb 5, 2024
Comment on lines
+41
to
+49
| exclude: | ||
| - eccube_version: 4.2 | ||
| php: 8.2 | ||
| - eccube_version: 4.2 | ||
| php: 8.3 | ||
| - eccube_version: 4.3 | ||
| php: 7.4 | ||
| - eccube_version: 4.3 | ||
| php: 8.0 |
There was a problem hiding this comment.
@dotani1111
excludeなので、該当のphpバージョンを除外したい、という意図になります。
dotani1111
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo 4.3でunit testを実行するようactionsを修正。手元では動作しています。以下4.2/4.3どちらもテスト通りました
https://github.com/EC-CUBE/ProductReview-plugin/actions/runs/7723096465