Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two bugs in timeSeriesStats output in MPAS-Ocean #5218

Closed
wants to merge 5 commits into from
Closed

Fix two bugs in timeSeriesStats output in MPAS-Ocean #5218

wants to merge 5 commits into from

Commits on Nov 4, 2022

  1. Fix start time for time series stats interval 

    Before this merge, it was incorrectly assumed to be one time
step before the current time.  The correct interval depends on
the compute interval, which has now been made available in the
form of the `computeInterval`.
    @xylar
    xylar committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    a072de8 View commit details
    Browse the repository at this point in the history

  2. Don't write Time and Time_bnds to AM restart files 

    These variables will get read back on restart into the main
system versions of these variables, which is not what we would
want.  Instead, on restart, Time_bnds(1) needs to be
recomputed from xtime_start
    @xylar
    xylar committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    2545f0e View commit details
    Browse the repository at this point in the history

  3. Switch timeSeriesStats to use simulationStartTime 

    Previously, timeSeriesStats was using the start time of the current
run as the beginning of stats.  Since this time starts over at
restarts, it was not triggering a reset of the stats as it should
have at the beginning of a restart interval that is commensurate
with the time-averaging interval.

With this merge, we now use the `simulationStartTime` to determine
when time-averaging began, so that alarms are correctly triggered
on restart.
    @xylar
    xylar committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    6a703ed View commit details
    Browse the repository at this point in the history

  4. Compute timeSeriesStats on startup unless restarting 

    With this merge, we copute timeSeriesStats on startup if we are
doing a fresh E3SM run but not if we are restarting.  This ensures
that we have a complete first day, month, etc.
    @xylar
    xylar committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    989d1a3 View commit details
    Browse the repository at this point in the history

  5. Update registry comments for compute_on_startup

    @xylar
    xylar committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    7e1a598 View commit details
    Browse the repository at this point in the history