-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new IcosXISC30E3r7 ocean and sea-ice mesh #85
Conversation
@jonbob, @proteanplanet, @cbegeman and @darincomeau, I have staged these files in @jonbob, unfortunately, this mesh will need new mapping and domain files. This does not need to be a fully supported mesh as far as I understand it. We only need mapping and domain files to be able to run a B-case that is essentially identical to the v3.LR.piControl run for this mesh. |
@@ -347,6 +357,7 @@ | |||
<config_land_ice_flux_mode ocn_grid="SOwISC12to60E2r4">'pressure_only'</config_land_ice_flux_mode> | |||
<config_land_ice_flux_mode ocn_grid="ECwISC30to60E2r1">'pressure_only'</config_land_ice_flux_mode> | |||
<config_land_ice_flux_mode ocn_grid="IcoswISC30E3r5">'pressure_only'</config_land_ice_flux_mode> | |||
<config_land_ice_flux_mode ocn_grid="IcosXISC30E3r7">'pressure_only'</config_land_ice_flux_mode> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting that, even though ice-shelf cavities have been culled, landIcePressure
is not zero in parts of the open ocean so this is needed.
@xylar Is |
@cbegeman, I believe that file is defined both inside and outside of cavities. It is not yet used anywhere but my understanding was that it would be useful to generate that file for all meshes, not just those with cavities, in case we wanted to use the tidal information elsewhere in the future. And, yes, in this case, I just generated all the Compass files for E3SM support because that was easier than trying to figure out which were needed and which were not. |
@xylar Sounds good. Just checking |
Hmm, I don't see any mention of that discussion in MPAS-Dev/compass#770, so maybe it was a mistake to include it for meshes without cavities. I'll check with @irenavankova to see what she thinks. |
@xylar I looked through the restart files, specifically the min and max values of each ocean variable in the culled and unculled restarts. All the I'll wait on the rest of my review until after we have at least a short simulation with the new mesh. |
The tidal file is only used in thermodynamically active cavities, but it is true that if other tidal parameterizations are implemented the same tidal file would likely be used in those cases as well and that would apply outside of cavities. However, the tidal file would have to be modified, as this one only includes Antarctica from the CATS2008 model |
@cbegeman, thanks for having a look. That high salinity value sounds odd but outside the scope of this particular project so we probably just want to keep it in the back of our minds as a possible issue to chase in the future.
Yes, sounds good. |
@irenavankova, thanks, those are great points. I made a Compass PR that I'll merge sortly to only produce these files in the future for meshes with cavities: |
OK, I added domain and mapping files to support this new mesh in limited configurations:
I ran a one-month G-case as a test and used the restart files to make alternate IC files for the B-case, if needed. All necessary files are staged in the local lcrc inputdata directory. Please let me know if you need anything else |
Wonderful, thank you @jonbob! We'll keep you posted and ask questions as they arise. |
To generate Latex documentation from the Registry, we need to escape Latex in the namelist and variable descriptions.
Sorry about the mess with my scripts -- the new mapping and domain files are replaced in this PR and on lcrc |
I ran ncks --chk_map on all the new mapping files and they all look good except
I checked some other mapping files for TL319 and they all seem to have a similar issue, so maybe conservation metrics make no sense for this situation |
Yes, I think that would be expected for bilinear maps both because they're not conservative by design and because we do need to be renormalizing them. |
Fix some formatting in MPAS-Ocean Registry for generating docs To generate Latex documentation from the Registry, we need to escape Latex in the namelist and variable descriptions. [BFB]
Comparison analysis of 10 year run using the culled ocn/ice restarts from the end of the v3 picontrol-spinup with v3 piControl: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on 10 year B-case test.
746e61c
to
133640e
Compare
closed in favor of E3SM-Project#6312 |
This mesh is identical to the
IcoswISC30E3r5
mesh except that ice-shelf cavities have been culled (eXcluded).The spun-up initial condition files (
mpaso.IcosXISC30E3r7.rstFromPiControlSpinup-chrysalis.20240314.nc
andmpassi.IcosXISC30E3r7.rstFromPiControlSpinup-chrysalis.20240314.nc
) are culled versions of the restart files from 2001-01-01 of the20231209.v3.LR.piControl-spinup.chrysalis
simulation (4032626741/20231209.v3.LR.piControl-spinup.chrysalis) with thextime
variable removed. These files have been culled with the tools added in MPAS-Dev/MPAS-Tools#557 to MPAS-Tools and in MPAS-Dev/compass#794 to Compass. The intention is to continue from these files so that we can compare with the v3.LR.piControl run.The remaining support files have been created by running
files_for_e3sm
from Compass on the culled MPAS-Ocean restart file. Thus, the ocean initial condition inmpaso.IcosXISC30E3r7.20240314.nc
should be identical, while the sea-ice initial condition inmpassi.IcosXISC30E3r7.20240314.nc
will just be the mesh variables and so on that allow sea ice to start from either a circular disk or no sea ice. We do not intend to make use of these initial conditions, just the "spun-up" versions.