✨ Rework v2 #18
✨ Rework v2 #18
Conversation
… And class is const
| // Test containing a list of enums | ||
|
|
||
| // enum TestEnum { | ||
| // one(3), |
There was a problem hiding this comment.
I don't think this example of the enum has to be here.
| }), | ||
| (int value) async { | ||
| final millis = DateTime.now().millisecondsSinceEpoch; | ||
| await Future<void>.delayed(Duration(milliseconds: value)); |
There was a problem hiding this comment.
Is this actually time awaited? Can't we use a test time skip method? Or at least just don't include this as an example as it seems bad practice?
There was a problem hiding this comment.
Added note about bad pratice
| [this], | ||
| TestOptions( | ||
| ( | ||
| values: [this], |
There was a problem hiding this comment.
Because this extension is used on a list of single values. For example:
parameterizedTest('singel values', [1,2,3], (int value) {...});The ValueWithTestOptions expects a list of values. Also the Function.apply expects a list of arguments even if there is only 1 argument.
| 9.0, | ||
| ]; | ||
|
|
||
| final result = pTest.makeDescription(baseDescription, 1, values, null); |
There was a problem hiding this comment.
What happens if we put a complex object with a custom .tostring in here, is that called for building the description? Can we test that?
There was a problem hiding this comment.
Added test. This is only sort of a thing when using the custom description builder. Normally the description is passed to the group test function which handles this out of the box. Also the custom description builder returns a Object which group will resolve.
| ], | ||
| (int value, String value2) => value + value2.length, | ||
| ), | ||
| throwsA(isA<ParameterizedError>()), |
There was a problem hiding this comment.
Could it be that there is a TypeError; but that error is not from the parameterizedTest. What whould happen then? Can we detect it and in that case rethrow the type error?
There was a problem hiding this comment.
Added check to see if error is from within the test body.
…peErrors not caught when from inside the test body
| extension StackTraceExtension on StackTrace { | ||
| /// Returns `true` if the stack trace is from within a test body | ||
| bool get isInsideTestBody { | ||
| final trace = Trace.from(this); |
New and improved inner workings of the library.
The new version makes it easier to use. No more need for specifying the extract amount of parameters you want to use!
Work in progress:
No csv support added but added reference and example by using csv package.