Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace domains with *.example.com ones #209 #210

Merged
merged 3 commits into from
Sep 22, 2024

Conversation

wenz
Copy link
Contributor

@wenz wenz commented Sep 18, 2024

Replaces alice.com, bob.com, and email.com with {alice|bob|email}.example.com.

Fixes #209

@wenz
Copy link
Contributor Author

wenz commented Sep 19, 2024

email.com now replaced with example.com.

@RolandGuijt
Copy link
Contributor

Thanks!

@RolandGuijt
Copy link
Contributor

We had some troubles that prevent us from merging this. Can you please the branch to the current main? @wenz

@wenz
Copy link
Contributor Author

wenz commented Sep 22, 2024

"This branch has no conflicts with the base branch" -> what should I do?

@josephdecock
Copy link
Member

There are fixes to the build in main that aren't in your branch, so we need to merge the latest from main into your branch (or rebase your branch onto that).

@wenz
Copy link
Contributor Author

wenz commented Sep 22, 2024

This should do it!

@josephdecock josephdecock merged commit ef083f6 into DuendeSoftware:main Sep 22, 2024
3 checks passed
@josephdecock
Copy link
Member

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use example.com subdomains instead of "real" domain names
3 participants