Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move package to proper lib subfolder as suggested by CPANTS. #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move package to proper lib subfolder as suggested by CPANTS. #29

wants to merge 1 commit into from

Conversation

manwar
Copy link

@manwar manwar commented Jan 17, 2017

Hi @rjbs

Please review the PR.

Many Thanks.
Best Regards,
Mohammad S Anwar

@smith153
Copy link
Collaborator

Hi,
Thanks for the PR and for the time you put into it. I'll have to check, but since Time::Piece is also included in core, I don't think the p5p maintainers like what they call "non code changes". That would include reindenting/retabbing, and certainly moving files around. Personally, I don't care, and I've thought of changing the lib directory before.

@rjbs
Copy link
Member

rjbs commented Jan 18, 2017

Time-Piece is upstream CPAN, meaning that the CPAN author can do what they like as long as they don't break things egregiously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manwar @smith153 @rjbs