Rt #122582 #60
Open
Rt #122582 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonerd
reviewed
Jan 5, 2018
t/dualvar.t
Outdated
| @@ -131,3 +131,6 @@ SKIP: { | |||
| ok(isdual($ary[2]), 'Is a dualvar'); | |||
| } | |||
|
|
|||
| # RT #122582: dual var not copying numeric value correctly | |||
| my $a = "4611686018427387915"; | |||
There was a problem hiding this comment.
This test is only going to pass correctly on 64bit perls surely?
leonerd
reviewed
Jan 5, 2018
| @@ -1200,7 +1200,7 @@ CODE: | |||
| SvIsUV_on(TARG); | |||
| } | |||
| #endif | |||
| else { | |||
| if(SvIOK(num)) { | |||
There was a problem hiding this comment.
If this else is going to disappear, I feel that the else on line 1197 above ought to too.
|
Just figured I should say I will take a look at this. I've just struggled to setup a 32 bit test perl without 64 bit int support easily so I haven't actually done anything with this yet. |
|
Sorry it's taken so long, but I've rebased and updated based on your feedback. I think the Travis fail is just a glitch, if you hit rebuilt it will probably work.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simplest possible fix for the test case described in RT #122582. This just ensures that the IV is copied over as well as the NV if present.
My knowledge of Perl internals isn't sufficient to really know if this is sufficient to fix the full bug described by zefram.