Define PERL_ARGS_ASSERT_CROAK_XS_USAGE when setting croak_xs_usage #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is matching what's done in ExtUtils::ParseXS::Utilities and avoids to redefine croak_xs_usage later. References: Dual-Life#194
|
See @khwilliamson commit 1ab5654 which you are basically reverting by this PR. |
|
Indeed this mostly reverted 1ab5654 which introduced this new warning |
|
The only reason I made that commit was because, as the message said, they were using a non-API element. Now, it may be that was needed because we don't use variadic macros, so the function must be specified using the Perl_ prefix, and this is a way around that. I haven't investigated. But if that is the case that should have clearly been spelled out. |
|
@khwilliamson any objections in merging this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is matching what's done in ExtUtils::ParseXS::Utilities
and avoids to redefine croak_xs_usage later.
References: #194