Add better error catching for announcement cron job

This should keep the announcement job from crapping out when a major error occurs
DreamExposure · Jun 23, 2024 · 2f6c1c7 · 2f6c1c7
1 parent d627a21
commit 2f6c1c7
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/...t/src/main/kotlin/org/dreamexposure/discal/client/business/cronjob/AnnouncementCronJob.kt b/...t/src/main/kotlin/org/dreamexposure/discal/client/business/cronjob/AnnouncementCronJob.kt
@@ -35,19 +35,23 @@ class AnnouncementCronJob(
     }
 
     private fun doAction() = mono {
-        val taskTimer = StopWatch()
-        taskTimer.start()
+        try {
+            val taskTimer = StopWatch()
+            taskTimer.start()
 
-        val guilds = discordClient.guilds.collectList().awaitSingle()
+            val guilds = discordClient.guilds.collectList().awaitSingle()
 
-        guilds.forEach { guild ->
-            try {
-                announcementService.processAnnouncementsForGuild(guild.id, maxDifference)
-            } catch (ex: Exception) {
-                LOGGER.error("Failed to process announcements for guild | guildId:${guild.id.asLong()}", ex)
+            guilds.forEach { guild ->
+                try {
+                    announcementService.processAnnouncementsForGuild(guild.id, maxDifference)
+                } catch (ex: Exception) {
+                    LOGGER.error("Failed to process announcements for guild | guildId:${guild.id.asLong()}", ex)
+                }
             }
+            taskTimer.stop()
+            metricService.recordAnnouncementTaskDuration("cronjob", taskTimer.totalTimeMillis)
+        } catch (ex: Exception) {
+            LOGGER.error(DEFAULT, "Announcement task failed for all guilds", ex)
         }
-        taskTimer.stop()
-        metricService.recordAnnouncementTaskDuration("cronjob", taskTimer.totalTimeMillis)
     }
 }