Actions: Updated to upload-artifact v4

DragonJoker · Oct 13, 2024 · 6378ab1 · 6378ab1
1 parent 67dcb92
commit 6378ab1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml
@@ -75,7 +75,7 @@ jobs:
         cmake --build . --config ${{ matrix.buildType }} --target clean
     - name: Upload success package
       if: (github.event_name == 'push') && (steps.build.conclusion == 'success')
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: ShaderWriter-${{ matrix.os[1] }}.zip
         path: ${{ github.workspace }}/ShaderWriter-${{ matrix.os[1] }}.zip
@@ -142,7 +142,7 @@ jobs:
         cmake --build . --config ${{ matrix.buildType }} --target clean
     - name: Upload success package
       if: (github.event_name == 'push') && (steps.build.conclusion == 'success')
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: ShaderWriter-${{ matrix.os[1] }}.zip
         path: ${{ github.workspace }}/ShaderWriter-${{ matrix.os[1] }}.zip
@@ -222,7 +222,7 @@ jobs:
         cmake --build . --config ${{ matrix.buildType }} --target clean
     - name: Upload success package
       if: (github.event_name == 'push') && (steps.build.conclusion == 'success')
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: ShaderWriter-${{ matrix.os[1] }}.zip
         path: ${{ github.workspace }}/ShaderWriter-${{ matrix.os[1] }}.zip
diff --git a/source/CompilerSpirV/SpirVHelpers.cpp b/source/CompilerSpirV/SpirVHelpers.cpp
@@ -1779,7 +1779,7 @@ namespace spirv
 
 	void ModuleConfig::addStorage( ast::var::VariablePtr var )
 	{
-		storages.emplace( var, false );
+		storages.try_emplace( var, false );
 	}
 
 	void ModuleConfig::makeWritable( ast::var::VariablePtr var )