reorganize code and better error handling

crates/rnote-ui/src/workspacebrowser/workspaceactions/createfolder.rs

@@ -62,24 +62,6 @@ pub(crate) fn create_folder(
     new_folder_action
 }
 
-pub(crate) fn open_folder(
-    workspacebrowser: &RnWorkspaceBrowser,
-    appwindow: &RnAppWindow,
-) -> gio::SimpleAction {
-    let open_folder_action = gio::SimpleAction::new("open-folder", None);
-
-    open_folder_action.connect_activate(clone!(@weak workspacebrowser, @weak appwindow => move |_, _| {
-        if let Some(parent_path) = workspacebrowser.dir_list_file().and_then(|f| f.path()) {
-            opener::open(parent_path).unwrap(); //for now not robust to errors
-            // maybe more things
-        } else {
-            tracing::warn!("Can't create new folder when there currently is no workspace selected");
-        }
-    }
-    ));
-
-    open_folder_action
-}
 fn create_folder_name_entry() -> Entry {
     Entry::builder()
         .placeholder_text(gettext("Folder Name"))

crates/rnote-ui/src/workspacebrowser/workspaceactions/mod.rs

@@ -1,6 +1,7 @@
 // Modules
 mod createfolder;
+mod openfolder;
 
 // Re-exports
 pub(crate) use createfolder::create_folder;
-pub(crate) use createfolder::open_folder;
+pub(crate) use openfolder::open_folder;

crates/rnote-ui/src/workspacebrowser/workspaceactions/openfolder.rs

@@ -0,0 +1,26 @@
+use crate::{RnAppWindow, RnWorkspaceBrowser};
+use gettextrs::gettext;
+use gtk4::{gio, glib, glib::clone, prelude::*};
+
+pub(crate) fn open_folder(
+    workspacebrowser: &RnWorkspaceBrowser,
+    appwindow: &RnAppWindow,
+) -> gio::SimpleAction {
+    let open_folder_action = gio::SimpleAction::new("open-folder", None);
+
+    open_folder_action.connect_activate(clone!(@weak workspacebrowser, @weak appwindow => move |_, _| {
+        if let Some(parent_path) = workspacebrowser.dir_list_file().and_then(|f| f.path()) {
+            if let Err(e) = opener::open(&parent_path) {
+                let path_string =   &parent_path.into_os_string().into_string().ok().unwrap_or(String::from("path not found"));
+                tracing::error!("Opening the parent folder '{path_string}' in the file manager failed, Err: {e:?}");
+                appwindow.overlays().dispatch_toast_error(&gettext("Failed to open the file in the file manager"));
+            }
+        } else {
+            tracing::warn!("No path found");
+            appwindow.overlays().dispatch_toast_error(&gettext("Failed to open the file in the file manager"));
+        }
+    }
+    ));
+
+    open_folder_action
+}