markdown support #73
Merged
markdown support #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
굿굿. 저도 확인했습니다~! |
|
#36 해결했습니다. |
|
ㅋㅋ 확인했어 근데 정작 markdown.js에서는 저 PR에 대해 소식이 없네.. |
|
@MujinChae 리뷰 해주세요! |
|
얘도 확인 했습니다~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
처음에는 redcarpet 을 써서 해보려고 했는데 일단 클라이언트단에서 클래스를 붙이는 방식으로 일단 먼저 해결봤습니다.
서버에서 처리하느냐 �클라이언트에서 처리하느냐 차이인데, markdown-js가 inline html을 모조리 escaping 하길래 일단 이 패치를 적용하였습니다.