NEW : hide external user in combobox #25740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EW_hide_external_user_in_combobox
atm-thibaultf
commented
Aug 30, 2023
Comment on lines
+519
to
+521
| if (!empty($conf->global->USER_HIDE_INACTIVE_IN_COMBOBOX)) { | ||
| $sql_usr .= " AND u.statut <> 0"; | ||
| } |
There was a problem hiding this comment.
adding this in the same time because it was missing
|
In Dolibarr, an external user is attached to a third-party (fk_soc > 0). So there will be a confusion between external and non employee users |
eldy
reviewed
Aug 31, 2023
| @@ -171,6 +171,9 @@ public function multiselectselectSalesRepresentatives($htmlname, $selected_array | |||
| if (!empty($conf->global->USER_HIDE_INACTIVE_IN_COMBOBOX)) { | |||
| $sql_usr .= " AND u2.statut<>0 "; | |||
| } | |||
| if (!empty($conf->global->USER_HIDE_EXTERNAL_IN_COMBOBOX)) { | |||
| $sql_usr .= " AND u2.employee<>0 "; | |||
There was a problem hiding this comment.
May be you mean USER_HIDE_NONEMPLOYEE_IN_COMBOBOX ? (external term is used for external users so fk_soc > 0).
If you really mean hide external user, condition should be AND u2.fk_soc IS NULL
There was a problem hiding this comment.
Indeed ! In the end, I have added the two options for non employee and external user if it's fine for you @eldy
eldy
added
the
Discussion
…hibaultf/dolibarr into NEW_hide_external_user_in_combobox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW|New hide external user in combobox
Adding configuration to hide external user in combobox and select