Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styles parameter to manual_legend (Redo) #1117

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

tktran
Copy link
Contributor

@tktran tktran commented Oct 11, 2020

[This is a redo of pull request #1094, since I (the contributor of the original PR) accidentally deleted the fork referenced by that PR.]
[One change from the original PR: the original PR included both the manual_legend styles code and code committed as part of #1097. I reverted the commit associated with 1097, so that this PR that you are looking at involves manual_legend improvements only.]

This PR is intended to fully implement issue #566. It includes unit tests for the new feature, and a bug fix for the existing manual_legend test (which failed to enable drawing the legend in the test image). It does not include updated documentation, which I would gladly begin working on upon approval of this PR. Also open to your suggested changes.

Questions for the DistrictDataLabs/team-oz-maintainers:

  • I set the default color of a legend entry (when none is specified in the colors nor styles parameter) to black. Please advise if there is a better option.

Checklist:

  • Is the commit message formatted correctly?
  • Have you noted the new functionality/bugfix in the release notes of the next release?
  • Included a sample plot to visually illustrate your changes? (see baseline image)
  • Do all of your functions and methods have docstrings?
  • Have you added/updated unit tests where appropriate?
  • Have you updated the baseline images if necessary?
  • Have you run the unit tests using pytest?
  • Is your code style correct (are you using PEP8, pyflakes)?
  • Have you documented your new feature/functionality in the docs?

Sets up tests/test_gridsearch with basic tests based on sample .ipynb. Only one change to gridsearch code (quick method return changed from None to visualizer).
Added styles parameter to manual_legend per issue DistrictDataLabs#566. With tests and bug fix for existing manual_legend test. (2nd fork after original deleted)
@bbengfort bbengfort self-assigned this Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants