Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement __eq__ between BaseFlags and flag_values #1238

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: implement __eq__ between BaseFlags and flag_values #1238

wants to merge 4 commits into from

Conversation

Sharp-Eyes
Copy link
Member

Summary

This PR adds support for __eq__ comparison between BaseFlags and flag_values.

For example,

>>> disnake.Intents(guilds=True) == disnake.Intents.guilds
True

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added the t: enhancement New feature label Oct 1, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
t: enhancement New feature
Projects
disnake
Status: Todo
Milestone
disnake v2.10
Development

Successfully merging this pull request may close these issues.
2 participants
@Sharp-Eyes @shiftinv