Fix exec creation #152
Merged
Fix exec creation #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Hey @DevNatan! Do you have a little time to review these three issues? |
DevNatan
reviewed
Apr 24, 2024
src/jvmMain/kotlin/me/devnatan/yoki/resource/container/ContainerResource.jvm.kt
Outdated
Show resolved
Hide resolved
DevNatan
approved these changes
Apr 24, 2024
|
@DevNatan I fixed the imports in all three MRs. I don't know why the CI runs native tests as most of it is not yet implemented. |
yep i'll disable CI tests, going to fix them soon you can merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the exec creation command to ExecResource to mirror the API.
It now correctly returns the exec instance id.