Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WP-698: NCO text search made case insensitive #1478

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Conversation

SilversunKSauri
Copy link
Contributor

Overview:

Mongodb queries by default are case insensitive, and NCO requested, if possible, for it to be made case-insensitive.

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

Added "i" flag to the regex queries that are part of the text search field to make them case-insensitive.

Testing Steps:

  1. Page is here: [local-url]/nco/ttc_grants
  2. search for "simpson" and "Simpson" should show the same results. Clear the search between attempts to make sure you're seeing the search happen. Also note that you have to click the search button manually for the search to happen.

UI Photos:

Notes:

Need to be on the vpn for the connection to the nco mongodb to work.
Also, this solution will work, but if the database grows much larger, this could cause the searches to become slow. However, due to how the search needs to be run, there's no way around this from my research.

@jarosenb jarosenb merged commit aaead94 into main Oct 23, 2024
5 checks passed
@jarosenb jarosenb deleted the task/wp-698 branch October 23, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants