Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/WP-694 : Provide mechanism to show UI for file selection on app arguments #1450

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

chandra-tacc
Copy link
Contributor

@chandra-tacc chandra-tacc commented Sep 24, 2024

Overview:

App users want UI selection modal for app parameters.
For example: OpenSees app has input parameter - which takes directory, and app parameter - which takes the driver file to load during running of the app. Only input parameters have file selection modal, with this PR, app parameters can also have file selection modals.

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  1. Change app definition to include this for specific apps. "notes": { "inputType": "fileInput" }. See PR WP-694: Provide mechanism to show UI for file selection on app arguments TACC/WMA-Tapis-Templates#57
  2. In DS Portal, update SelectModal to handle both tapis:// value representation or just name of the file. Update the input parameters accordingly.

Testing Steps:

  1. Test https://designsafe.dev/rw/workspace/opensees-sp-s3?appVersion=3.6.0. This allows both tapisFile and standard file selection. So, tests both the areas.
  2. Use selection and submit job.

UI Photos:

Screenshot 2024-09-24 at 2 28 11 PM Screenshot 2024-09-24 at 2 28 06 PM

Notes:

There could be better UI here:

  • make app parameter dependent on the input parameter. And set the default path in the select modal to what the input path uses. For example, for OpenSees app, select the Main Script file selection modal to default to input directory value (if it is already set). This requires a way to associate two parameters (app and input) via notes in app schema
  • Another feature is make the select modal navigate to the path, if it is available. Today, it only navigates to the storage system root.

@chandra-tacc chandra-tacc changed the title Task/wp 694 arg file selector Task/WP-694 : Provide mechanism to show UI for file selection on app arguments Sep 24, 2024
@chandra-tacc chandra-tacc marked this pull request as ready for review September 24, 2024 20:29
Copy link
Contributor

@fnets fnets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works locally. I'd agree with your notes about UI tweaks, because I'm not sure if using the UI to re-navigate to the working directory is any easier than just writing the filename into the input field.

@rstijerina rstijerina merged commit 37a4c36 into main Oct 2, 2024
5 checks passed
@rstijerina rstijerina deleted the task/WP-694-arg-file-selector branch October 2, 2024 19:05
@chandra-tacc
Copy link
Contributor Author

Opened jira WP-705 to track improvement notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants