Task/wg 375 recon portal UI changes #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes external dataset header and toggle and associated styles - Adds debounced search button for each row - Changes order of Clear and Hide buttons, adds filter to the wording in the button - Adds checkbox to hide and add Recon Portal data
shayanaijaz
approved these changes
Sep 24, 2024
| <div class="filter-button-row"> | ||
| <button class="btn btn-xs btn-default filter-btn" ng-click="vm.show_filter_options=false"> Hide Filters </button> | ||
| <button class="btn btn-xs btn-default filter-btn" ng-click="vm.clear_filters()"> Clear Filters </button> | ||
| <button class="btn btn-xs btn-info filter-btn" ng-click="vm.debouncedSearch()" ng-disabled="(!vm.data_source && !vm.ot_data_source)"> Search </button> |
There was a problem hiding this comment.
Since there is a proper search button now we don't have to worry about debouncing the search so we should be able to use search() directly
There was a problem hiding this comment.
The search in the sidebar still uses this function. Should that change to the search method instead as well? I think the auto-updating in that area makes sense but we will probably have to defer to CMD on that UI anyway. I can remove it and implement the search the same way as the filter though if you think that would be better.
handles this through the service - Search button uses search method on click rather than debouncing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Requested UI changes from Tracy before 4Kitchens and CMD design review
PR Status:
Related Jira tickets:
Summary of Changes:
to the wording in the button
Testing Steps:
UI Photos:
Main screen with filters showing
No dataset match for filters
Notes: