Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

des-2512-more-text-changes--mostly-hyb-sim #1098

Merged
merged 3 commits into from
Oct 2, 2023
Merged

des-2512-more-text-changes--mostly-hyb-sim #1098

merged 3 commits into from
Oct 2, 2023

Conversation

van-go
Copy link
Contributor

@van-go van-go commented Sep 26, 2023 •
edited
Loading

Overview:

More text changes that mostly relate to Hybrid Sim

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  • DES-2517: Updated amends text in amend-hybrid-sim.template.html
    Updated Confirm Author section in version-hyb-sim-citation.template.html
  • DES-2518: Updated Version text -- changed 'publication' to 'project in version-hyb-sim-selection.template.html as well as field-recon, experiment, simulation

Testing Steps:

  1. work your way down the publication pipeline, primarily for project type HybSim

UI Photos:

Screen Shot 2023-09-26 at 5 07 23 PM
Screen Shot 2023-09-26 at 5 08 01 PM
Screen Shot 2023-09-26 at 5 08 40 PM

Notes:

jarosenb
jarosenb approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@jarosenb jarosenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarosenb jarosenb merged commit 0ac7f0b into main Oct 2, 2023
2 checks passed
@jarosenb jarosenb deleted the task/des-2512-more-text-updates branch October 2, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarosenb jarosenb jarosenb approved these changes

@SilversunKSauri SilversunKSauri Awaiting requested review from SilversunKSauri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@van-go @jarosenb