-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task/DES-2562: Add Scratch (Frontera)
to listings
#1082
Merged
jarosenb
merged 6 commits into
task/DES-2561--create-myworkingfiles-dir
from
task/DES-2562--myworkingfiles-listing
Aug 23, 2023
Merged
task/DES-2562: Add Scratch (Frontera)
to listings
#1082
jarosenb
merged 6 commits into
task/DES-2561--create-myworkingfiles-dir
from
task/DES-2562--myworkingfiles-listing
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer needed, we are updated |
rstijerina
requested changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated for designsafe.storage.frontera.scratch
designsafe/static/scripts/data-depot/components/data-depot-nav/data-depot-nav.component.js
Outdated
Show resolved
Hide resolved
...safe/static/scripts/data-depot/components/data-depot-toolbar/data-depot-toolbar.component.js
Outdated
Show resolved
Hide resolved
designsafe/static/scripts/ng-designsafe/services/file-operation-service.js
Outdated
Show resolved
Hide resolved
...atic/scripts/workspace/components/workspace-data-browser/workspace-data-browser.component.js
Outdated
Show resolved
Hide resolved
...atic/scripts/workspace/components/workspace-data-browser/workspace-data-browser.component.js
Outdated
Show resolved
Hide resolved
rstijerina
changed the title
task/DES-2562: Add My Data (Work) to listings
task/DES-2562: Add Aug 22, 2023
Scratch (Frontera)
to listings
Co-authored-by: Sal Tijerina <[email protected]>
jarosenb
changed the base branch from
main
to
task/DES-2561--create-myworkingfiles-dir
August 23, 2023 15:43
…-2562--myworkingfiles-listing
jarosenb
merged commit Aug 23, 2023
21198e5
into
task/DES-2561--create-myworkingfiles-dir
2 checks passed
jarosenb
added a commit
that referenced
this pull request
Aug 29, 2023
* create myworkingfiles dir on login * add missing setting * Update designsafe/settings/common_settings.py * task/DES-2562: Add `Scratch (Frontera)` to listings (#1082) * Add My Data (Work) to listings * update name to My Working Data * update name to My Working Files * Apply suggestions from code review Co-authored-by: Sal Tijerina <[email protected]> --------- Co-authored-by: Jake Rosenberg <[email protected]> Co-authored-by: Sal Tijerina <[email protected]> * update labels to Working Files (scratch Frontera) --------- Co-authored-by: Jake Rosenberg <[email protected]> Co-authored-by: Jake Rosenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Add
Scratch (Frontera)
as a nav option in the Data Depot and Workspace.PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
UI Photos:
Notes: