Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licences not displaying properly for Exp & HybSim #1080

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

van-go
Copy link
Contributor

@van-go van-go commented Aug 1, 2023

Overview:

In Pub Preview, an extra (Appears when published) was appearing. It was determined to be for the "License(s)" section of the metadata.

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

In both cases, a conditional statement that would display "License(s)" was not working correctly because one of the conditions was from the wrong project type (FR), rather than HybSim or Exp.

Testing Steps:

For all project types, find a project with a License and make sure the correct text appears.

UI Photos:

BEFORE
Screen Shot 2023-08-01 at 12 33 27 PM

AFTER
Screen Shot 2023-08-01 at 12 34 11 PM

Notes:

Copy link
Contributor

@SilversunKSauri SilversunKSauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarosenb jarosenb merged commit 7526a16 into main Aug 15, 2023
2 checks passed
@jarosenb jarosenb deleted the task/des-2554-extra-appears-when-published branch August 15, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants