task/WP-673: Interactive Modal Redesign #2862
main.yml
on: pull_request
Server_Side_Unit_Tests
1m 2s
Server_Side_Linting
25s
Client_Side_Unit_Tests
59s
React_NX_unit_tests
1m 9s
React_NX_linting
27s
Annotations
7 errors and 12 warnings
React_NX_linting:
client/modules/workspace/src/AppsSubmissionForm/AppsSubmissionForm.tsx#L78
'_' is assigned a value but never used
|
React_NX_linting
Redundant double negation
|
React_NX_linting
Redundant double negation
|
React_NX_linting:
client/modules/workspace/src/JobsListing/JobsListing.tsx#L1
'useState' is defined but never used
|
React_NX_linting:
client/modules/workspace/src/JobsListing/JobsListing.tsx#L66
'_' is assigned a value but never used
|
React_NX_linting:
client/modules/workspace/src/Toast/Toast.tsx#L38
Expected a 'break' statement before 'case'
|
React_NX_linting
Process completed with exit code 1.
|
Server_Side_Linting
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
React_NX_linting:
client/modules/datafiles/src/projects/modals/ChangeProjectTypeModal.tsx#L133
React Hook useMemo has a missing dependency: 'showProtectedDataOptions'. Either include it or remove the dependency array
|
React_NX_linting:
client/modules/datafiles/src/projects/modals/ProjectInfoStepper/ExperimentalSteps.tsx#L168
The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value. If you cannot provide an href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/HEAD/docs/rules/anchor-is-valid.md
|
React_NX_linting:
client/modules/datafiles/src/projects/modals/ProjectInfoStepper/SimulationSteps.tsx#L167
The href attribute is required for an anchor to be keyboard accessible. Provide a valid, navigable address as the href value. If you cannot provide an href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/HEAD/docs/rules/anchor-is-valid.md
|
React_NX_linting:
client/src/workspace/layouts/AppsViewLayout.tsx#L51
Using target="_blank" without rel="noreferrer" (which implies rel="noopener") is a security risk in older browsers: see https://mathiasbynens.github.io/rel-noopener/#recommendations
|
React_NX_linting:
client/modules/workspace/src/AppsSubmissionForm/AppsSubmissionForm.tsx#L137
React Hook useMemo has missing dependencies: 'appId', 'appVersion', 'configuration.defaults', 'fileInputs.defaults', 'outputs.defaults', and 'parameterSet.defaults'. Either include them or remove the dependency array
|
React_NX_linting:
client/modules/workspace/src/AppsSubmissionForm/AppsSubmissionForm.tsx#L227
React Hook useMemo has a missing dependency: 'getSteps'. Either include it or remove the dependency array
|
React_NX_linting:
client/modules/workspace/src/AppsSubmissionForm/AppsSubmissionForm.tsx#L249
React Hook useEffect has missing dependencies: 'getInitialCurrentStep', 'getSteps', and 'reset'. Either include them or remove the dependency array
|
React_NX_linting:
client/modules/workspace/src/AppsSubmissionForm/AppsSubmissionForm.tsx#L297
React Hook React.useEffect has missing dependencies: 'allocations', 'definition', 'execSystems', and 'getValues'. Either include them or remove the dependency array
|
React_NX_linting:
client/modules/workspace/src/AppsSubmissionForm/AppsSubmissionForm.tsx#L336
React Hook useEffect has a missing dependency: 'steps'. Either include it or remove the dependency array
|
React_NX_linting:
client/modules/workspace/src/AppsSubmissionForm/AppsSubmissionForm.tsx#L346
React Hook useCallback has missing dependencies: 'fieldValues' and 'steps'. Either include them or remove the dependency array
|
Server_Side_Unit_Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|