This repository has been archived by the owner on Jul 21, 2024. It is now read-only.
학교 정보 입력 기능 개발 (#61) #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JWT를 위한 사용자 id 추가
98StarJune
reviewed
Oct 12, 2023
server/Interface/IUserService.cs
Outdated
| @@ -4,6 +4,8 @@ namespace server.Interface; | |||
|
|
|||
| interface IUserService | |||
| { | |||
| public Task<bool> Create(CreateUserRequest body); | |||
| public Task<AuthResponse> Create(CreateUserRequest body); | |||
There was a problem hiding this comment.
확인필요
Interface 상의 Return Type은 Task이나, 구현된 Controller에서는 Task<ActionResult> 입니다.
| @@ -4,6 +4,8 @@ namespace server.Interface; | |||
|
|
|||
| interface IUserService | |||
| { | |||
| public Task<bool> Create(CreateUserRequest body); | |||
| public Task<AuthResponse> Create(CreateUserRequest body); | |||
| public Task<bool> AddSchoolInfo(long id, CreateSchoolRequest body); | |||
주의사항본 PR에 대해서 Merge 진행 시 Conflict가 발생할 수 있습니다. Conflict 해결 시 코드 선택에 유의해주시기 바랍니다. |
|
이상 없습니다. 재확인 바랍니다. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
사용자가 학교 정보를 입력할 수 있는 기능입니다.
세부 내용
SchoolInformationEntity 엔티티 추가
UserController의 AddSchoolInfo 메서드 추가
UserService의 AddSchoolInfo 메서드 추가
IUserService의 AddSchoolInfo 메서드 추가
CreateSchoolRequest DTO 추가