Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix license warning #447

Closed
wants to merge 1 commit into from
Closed

fix license warning #447

wants to merge 1 commit into from

Conversation

waynexia
Copy link
Contributor

Signed-off-by: Ruihang Xia [email protected]

What does this PR do?

Run cargo-license script and update the license list

Motivation

#446 (comment)

Related issues

n/a

Additional Notes

script:

cargo license --all-features -a -j --no-deps -d | jq -r '(["Component","Origin","License","Copyright"]) as $cols | map(. as $row | ["name", "repository", "license", "authors"] | map($row[.])) as $rows | $cols, $rows[] | @csv' > LICENSE-3rdparty.csv

Checklist

[] I have added unit tests to the code I am submitting
[] My unit tests cover both failure and success scenarios
[] If applicable, I have discussed my architecture

Signed-off-by: Ruihang Xia <[email protected]>
@glommer
Copy link
Collaborator

glommer commented Oct 19, 2021

@HippoBaro - I thought this was all good already ?

@github-actions
Copy link

Greetings @waynexia!

It looks like your PR added a new or changed an existing dependency, and CI has failed to validate your changes.
Some possible reasons this could happen:

  • One of the dependencies you added uses a restricted license. See deny.toml for a list of licenses we allow;
  • One of the dependencies you added has a known security vulnerability;
  • You added or updated a dependency and didn't update the LICENSE-3rdparty.csv file. To do so, run the following and commit the changes:
$ cargo install cargo-license
$ cargo license --all-features -a -j --no-deps -d | jq -r '(["Component","Origin","License","Copyright"]) as $cols | map(. as $row | ["name", "repository", "license", "authors"] | map($row[.])) as $rows | $cols, $rows[] | @csv' > LICENSE-3rdparty.csv

Thank you!

@HippoBaro
Copy link
Member

Hey @waynexia I'm running the above command on master's HEAD (4e6b147) and that yields no diff. Are you sure your branch is up-to-date with master?

@waynexia
Copy link
Contributor Author

It's weird... My base commit is 4e6b147 too. Output of git log:

2075b39 (HEAD -> fix-license, origin/fix-license) fix license warning
4e6b147 (upstream/master, upstream/HEAD, origin/master, master) Udp options (#443)
05e704b shared channel: ensure timely wake (#442)

Let me take a look.

@waynexia
Copy link
Contributor Author

My local crates cache is outdated. Now I got the same output with master.

And I checked #446 (comment), it's caused by some security problems, not license job. I'll close this pr and sorry for disturbing 😋

@waynexia waynexia closed this Oct 20, 2021
@HippoBaro
Copy link
Member

No worries! If I get some free time I'll try to get the bot to post the output of the job in the comment rather than just a vague generic message :) Should me things easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants