WIP api security sampling #4766
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2024-10-09 13:22:36 Comparing candidate commit 832800a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics. |
iunanua
force-pushed
the
igor/api-security-sampling-ilyas
branch
from
448d9dd
to
832800a
Compare
iunanua
commented
Oct 9, 2024
| @@ -70,7 +65,7 @@ function isSampled (req, res) { | |||
| function computeKey (req, res) { | |||
| const route = req.route?.path || req.url | |||
| const method = req.method.toLowerCase() | |||
| const statusCode = res.statusCode | |||
| const statusCode = res.statusCode === 304 ? 200 : res.statusCode | |||
There was a problem hiding this comment.
this is funny because sometimes, for the same request, status code is 200 in onResponseBody but 304 in incomingHttpEndTranslator. It depends on when you are trying to get it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Plugin Checklist
Additional Notes