Replace manual.keep tag usage with an specific method to keep the span #4739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PrioritySampler.setPriority(span, samplingPriority, mechanism)
method to allow to set an span priority directly.DatadogSpan.keep()
method which setsUSER_KEEP
priority, allowing to specify the sampling mechanism.manual.keep
tag in appsec and iast modules with theDatadogSpan.keep()
method.Motivation
Modules like appsec and iast use
manual.keep
tag when they want to indicate the tracer to keep the trace.But this is not entirely correct because some times priority has been set on the creation of the trace and adding
manual.keep
tag has no effect in the trace's priority.Plugin Checklist
Additional Notes