Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.21.0 proposal #4590

Merged
merged 19 commits into from
Aug 13, 2024
Merged

v5.21.0 proposal #4590

merged 19 commits into from
Aug 13, 2024

Conversation

uurien
Copy link
Collaborator

@uurien uurien commented Aug 9, 2024

Fixes

Improvements

Not to add in release notes

Copy link

github-actions bot commented Aug 9, 2024

Overall package size

Self size: 6.93 MB
Deduped: 58.15 MB
No deduping: 58.43 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Aug 9, 2024

Benchmarks

Benchmark execution time: 2024-08-13 07:21:38

Comparing candidate commit 725f161 in PR branch v5.21.0-proposal with baseline commit 6c5fe61 in branch v5.x.

Found 1 performance improvements and 12 performance regressions! Performance is the same for 247 metrics, 6 unstable metrics.

scenario:appsec-control-18

  • 🟥 cpu_user_time [+32.701ms; +40.125ms] or [+8.968%; +11.004%]
  • 🟥 execution_time [+25.259ms; +51.990ms] or [+5.638%; +11.606%]
  • 🟥 instructions [+50.4M instructions; +51.3M instructions] or [+5.839%; +5.942%]

scenario:appsec-control-with-attacks-18

  • 🟥 cpu_user_time [+30.411ms; +38.001ms] or [+8.778%; +10.969%]
  • 🟥 instructions [+50.4M instructions; +51.1M instructions] or [+5.786%; +5.868%]

scenario:log-skip-log-18

  • 🟥 execution_time [+27.813ms; +28.591ms] or [+5.525%; +5.680%]

scenario:log-with-debug-18

  • 🟥 execution_time [+27.785ms; +28.566ms] or [+5.520%; +5.675%]

scenario:log-with-error-18

  • 🟥 cpu_user_time [+22.953ms; +32.721ms] or [+5.026%; +7.165%]
  • 🟥 execution_time [+28.041ms; +28.715ms] or [+5.572%; +5.705%]

scenario:log-without-log-18

  • 🟥 execution_time [+28.643ms; +30.150ms] or [+5.883%; +6.192%]

scenario:net-with-tracer-18

  • 🟥 instructions [+49.5M instructions; +49.9M instructions] or [+5.818%; +5.862%]

scenario:plugin-bluebird-with-tracer-18

  • 🟥 instructions [+50.0M instructions; +51.1M instructions] or [+6.006%; +6.132%]

scenario:plugin-graphql-with-depth-and-collapse-off-18

  • 🟩 max_rss_usage [-254.713MB; -136.579MB] or [-18.381%; -9.856%]

@uurien uurien marked this pull request as ready for review August 12, 2024 07:08
@uurien uurien requested a review from a team as a code owner August 12, 2024 07:08
juan-fernandez
juan-fernandez previously approved these changes Aug 12, 2024
Copy link
Collaborator

@juan-fernandez juan-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed two items from the release notes and it now looks good from test visibility's perspective. Thanks!

@uurien uurien merged commit 725f161 into v5.x Aug 13, 2024
175 checks passed
@uurien uurien deleted the v5.21.0-proposal branch August 13, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants