Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTP-387] Check mutating config registered #30290

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gabedos
Copy link
Contributor

@gabedos gabedos commented Oct 18, 2024

What does this PR do?

Checks whether the Agent registers a mutating webhook configuration.

Motivation

Provide testing that the agent is able to create/register a critical webhook configuration.

Describe how to test/QA your changes

inv new-e2e-tests.run --targets ./tests/containers/ --run TestEKSSuite and confirmed passing tests.
The agent configuration should create mutating webhooks to inject things like DD_ENV, DD_SERVICE, etc. into containers.

Possible Drawbacks / Trade-offs

This is an additional test to all k8s test suites, however, it doesn't require any new resources to be created on the infra side. Should not have any effect on the runtime of tests.

@github-actions github-actions bot added the team/container-platform The Container Platform Team label Oct 18, 2024
@gabedos gabedos added this to the 7.60.0 milestone Oct 18, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 46944648 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@gabedos gabedos added the qa/done Skip QA week as QA was done before merge and regressions are covered by tests label Oct 18, 2024
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=46944648 --os-family=ubuntu

Note: This applies to commit f69438c

Copy link

Regression Detector

Regression Detector Results

Run ID: 6d0a060e-b44f-44b0-82fc-baa3b7735671 Metrics dashboard Target profiles

Baseline: 1c49cec
Comparison: f69438c

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.45 [-0.28, +1.18] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.44 [-0.04, +0.93] 1 Logs
otel_to_otel_logs ingress throughput +0.28 [-0.53, +1.09] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.14 [-0.11, +0.40] 1 Logs
idle_all_features memory utilization +0.07 [-0.03, +0.18] 1 Logs bounds checks dashboard
file_to_blackhole_300ms_latency egress throughput +0.03 [-0.16, +0.21] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.09, +0.12] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.34, +0.33] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.23, +0.22] 1 Logs
idle memory utilization -0.13 [-0.18, -0.08] 1 Logs bounds checks dashboard
file_tree memory utilization -0.20 [-0.32, -0.08] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.23 [-0.28, -0.18] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.52 [-3.04, +2.00] 1 Logs
basic_py_check % cpu utilization -1.40 [-4.12, +1.33] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10
idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/container-platform The Container Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant